Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MaterialInteractionAssignment empty intersections safety check #3158

Merged
merged 4 commits into from
Apr 30, 2024
Merged

fix: MaterialInteractionAssignment empty intersections safety check #3158

merged 4 commits into from
Apr 30, 2024

Conversation

ssdetlab
Copy link
Contributor

Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing intersectedSurfaces in the materialInteractions loop.

@github-actions github-actions bot added the Component - Core Affects the Core module label Apr 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

📊: Physics performance monitoring for 3e6442c

Full contents

physmon summary

@AJPfleger AJPfleger added this to the next milestone Apr 30, 2024
@kodiakhq kodiakhq bot merged commit 16ac510 into acts-project:main Apr 30, 2024
51 checks passed
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [16ac510]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsConversionWorkflow
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@ssdetlab @EleniXoch
fix: MaterialInteractionAssignment empty intersections safety check (a…
34bb5e9 
…cts-project#3158)

Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing `intersectedSurfaces` in the `materialInteractions` loop.
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@ssdetlab @asalzburger
fix: MaterialInteractionAssignment empty intersections safety check (a…
e46b3e0 
…cts-project#3158)

Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing `intersectedSurfaces` in the `materialInteractions` loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module
Projects
None yet
Milestone
v35.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ssdetlab @acts-project-service @andiwand @AJPfleger